Chobit Integration #1

New Issue

brister · 2026-03-11T04:55:13Z

brister commented

2026-03-11 04:55:13 +00:00

Backstory

Previously, it was thought that Chobit integration was not needed, as DLSite integrations provided a HasDLPlay flag to (supposedly) indicate if the audio product had a demo samples provided by Chobit. This does not seem to be the case 100% of the time, so Chobit integrations will need to be integrated into the scanning/ingestion process.

Update: Apparently, the HasDLPlay flag has no bearing on whether or not there are Chobit samples available. Therefore, the HasDLPlay flag will be completely disregarded when building ingestion objects in future scans.

Technicals

The infrastrcture will need to be rewritten slightly, in terms of HTTP services and tests using those HTTP services.

Tasks

Deprecate IHttpService in favor of HttpClient
Update tests that are/were using/mocking IHttpService
Create separate http clients to inject DLSiteClient and ChobitClient
Add Chobit tests
Chobit tests pass
Incorporate Chobit into the scan/ingestion process
Update ingestion tests
Ingestion tests pass

Update: Added pull request: #2

# Backstory Previously, it was thought that Chobit integration was not needed, as DLSite integrations provided a `HasDLPlay` flag to (supposedly) indicate if the audio product had a demo samples provided by Chobit. This does not seem to be the case 100% of the time, so Chobit integrations will need to be integrated into the scanning/ingestion process. **Update:** Apparently, the `HasDLPlay` flag has no bearing on whether or not there are Chobit samples available. Therefore, the `HasDLPlay` flag will be completely disregarded when building ingestion objects in future scans. # Technicals The infrastrcture will need to be rewritten slightly, in terms of HTTP services and tests using those HTTP services. # Tasks - [x] Deprecate `IHttpService` in favor of `HttpClient` - [x] Update tests that are/were using/mocking `IHttpService` - [x] Create separate http clients to inject `DLSiteClient` and `ChobitClient` - [x] Add Chobit tests - [x] Chobit tests pass - [x] Incorporate Chobit into the scan/ingestion process - [x] Update ingestion tests - [x] Ingestion tests pass **Update:** Added pull request: #2

brister self-assigned this 2026-03-11 04:55:41 +00:00

brister added reference feature/issue-1-chobit-integration

2026-03-15 02:32:06 +00:00

brister commented

2026-03-15 02:36:46 +00:00

Chobit integration has been merged. Closing the ticket.

brister closed this issue

2026-03-15 02:36:47 +00:00

brister added the

bug

label 2026-03-15 02:38:22 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: brister/jsmr#1