brister/jsmr
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Chobit Integration #1

New Issue
Open
opened 2026-03-11 04:55:13 +00:00 by brister · 0 comments
brister commented 2026-03-11 04:55:13 +00:00
Owner
Copy Link

Backstory

Previously, it was thought that Chobit integration was not needed, as DLSite integrations provided a HasDLPlay flag to (supposedly) indicate if the audio product had a demo samples provided by Chobit. This does not seem to be the case 100% of the time, so Chobit integrations will need to be integrated into the scanning/ingestion process.

Technicals

The infrastrcture will need to be rewritten slightly, in terms of HTTP services and tests using those HTTP services.

Tasks

  • Deprecate IHttpService in favor of HttpClient
  • Update tests that are/were using/mocking IHttpService
  • Create separate http clients to inject DLSiteClient and ChobitClient
  • Add Chobit tests
  • Chobit tests pass
  • Incorpoate Chobit into the scan/ingestion process
  • Update ingestion tests
  • Ingestion tests pass
# Backstory Previously, it was thought that Chobit integration was not needed, as DLSite integrations provided a HasDLPlay flag to (supposedly) indicate if the audio product had a demo samples provided by Chobit. This does not seem to be the case 100% of the time, so Chobit integrations will need to be integrated into the scanning/ingestion process. # Technicals The infrastrcture will need to be rewritten slightly, in terms of HTTP services and tests using those HTTP services. # Tasks - [ ] Deprecate `IHttpService` in favor of `HttpClient` - [ ] Update tests that are/were using/mocking `IHttpService` - [ ] Create separate http clients to inject `DLSiteClient` and `ChobitClient` - [ ] Add Chobit tests - [ ] Chobit tests pass - [ ] Incorpoate Chobit into the scan/ingestion process - [ ] Update ingestion tests - [ ] Ingestion tests pass
brister self-assigned this 2026-03-11 04:55:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
brister
No Assignees brister
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: brister/jsmr#1
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?